-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clientside callbacks #30
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,208 @@ | ||
| import HTTP, JSON2 | ||
| using Test | ||
| using Dash | ||
|
|
||
| @testset "callid" begin | ||
| id = callid"id1.prop1 => id2.prop2" | ||
| @test id isa CallbackId | ||
| @test length(id.state) == 0 | ||
| @test length(id.input) == 1 | ||
| @test length(id.output) == 1 | ||
| @test id.input[1] == (:id1, :prop1) | ||
| @test id.output[1] == (:id2, :prop2) | ||
|
|
||
| id = callid"{state1.prop1, state2.prop2} input1.prop1, input2.prop2 => output1.prop1, output2.prop2" | ||
| @test id isa CallbackId | ||
| @test length(id.state) == 2 | ||
| @test length(id.input) == 2 | ||
| @test length(id.output) == 2 | ||
| @test id.input[1] == (:input1, :prop1) | ||
| @test id.input[2] == (:input2, :prop2) | ||
| @test id.output[1] == (:output1, :prop1) | ||
| @test id.output[2] == (:output2, :prop2) | ||
| @test id.state[1] == (:state1, :prop1) | ||
| @test id.state[2] == (:state2, :prop2) | ||
| end | ||
|
|
||
| @testset "callback!" begin | ||
| app = dash() | ||
| app.layout = html_div() do | ||
| dcc_input(id = "my-id", value="initial value", type = "text"), | ||
| html_div(id = "my-div") | ||
| end | ||
|
|
||
| callback!(app, callid"my-id.value => my-div.children") do value | ||
| return value | ||
| end | ||
| @test length(app.callbacks) == 1 | ||
| @test haskey(app.callbacks, Symbol("my-div.children")) | ||
| @test app.callbacks[Symbol("my-div.children")].func("test") == "test" | ||
|
|
||
| handler = make_handler(app) | ||
| request = HTTP.Request("GET", "/_dash-dependencies") | ||
| resp = HTTP.handle(handler, request) | ||
| deps = JSON2.read(String(resp.body)) | ||
|
|
||
| @test length(deps) == 1 | ||
| cb = deps[1] | ||
| @test cb.output == "my-div.children" | ||
| @test cb.inputs[1].id == "my-id" | ||
| @test cb.inputs[1].property == "value" | ||
| @test :clientside_function in keys(cb) | ||
| @test isnothing(cb.clientside_function) | ||
|
|
||
| app = dash() | ||
| app.layout = html_div() do | ||
| dcc_input(id = "my-id", value="initial value", type = "text"), | ||
| html_div(id = "my-div"), | ||
| html_div(id = "my-div2") | ||
| end | ||
| callback!(app, callid"{my-id.type} my-id.value => my-div.children, my-div2.children") do state, value | ||
| return state, value | ||
| end | ||
| @test length(app.callbacks) == 1 | ||
| @test haskey(app.callbacks, Symbol("..my-div.children...my-div2.children..")) | ||
| @test app.callbacks[Symbol("..my-div.children...my-div2.children..")].func("state", "value") == ("state", "value") | ||
|
|
||
| app = dash() | ||
|
|
||
| app.layout = html_div() do | ||
| dcc_input(id = "my-id", value="initial value", type = "text"), | ||
| html_div(id = "my-div"), | ||
| html_div(id = "my-div2") | ||
| end | ||
|
|
||
| callback!(app, callid"my-id.value => my-div.children") do value | ||
| return value | ||
| end | ||
| callback!(app, callid"my-id.value => my-div2.children") do value | ||
| return "v_$(value)" | ||
| end | ||
|
|
||
| @test length(app.callbacks) == 2 | ||
| @test haskey(app.callbacks, Symbol("my-div.children")) | ||
| @test haskey(app.callbacks, Symbol("my-div2.children")) | ||
| @test app.callbacks[Symbol("my-div.children")].func("value") == "value" | ||
| @test app.callbacks[Symbol("my-div2.children")].func("value") == "v_value" | ||
|
|
||
| @test_throws ErrorException callback!(app, callid"my-id.value => my-div2.children") do value | ||
| return "v_$(value)" | ||
| end | ||
|
|
||
| @test_throws ErrorException callback!(app, callid"{my-id.value} my-id.value => my-id.value") do value | ||
| return "v_$(value)" | ||
| end | ||
|
|
||
| @test_throws ErrorException callback!(app, callid"my-div.children, my-id.value => my-id.value") do value | ||
| return "v_$(value)" | ||
| end | ||
| @test_throws ErrorException callback!(app, callid"my-id.value => my-div.children, my-id.value") do value | ||
| return "v_$(value)" | ||
| end | ||
|
|
||
| @test_throws ErrorException callback!(app, callid" => my-div2.title, my-id.value") do value | ||
| return "v_$(value)" | ||
| end | ||
|
|
||
| @test_throws ErrorException callback!(app, callid"my-id.value => my-div2.title, my-div2.title") do value | ||
| return "v_$(value)" | ||
| end | ||
|
|
||
| @test_throws ErrorException callback!(app, callid"my-id.value => my-div2.title") do | ||
| return "v_" | ||
| end | ||
|
|
||
|
|
||
| app = dash() | ||
| app.layout = html_div() do | ||
| dcc_input(id = "my-id", value="initial value", type = "text"), | ||
| html_div("test2", id = "my-div"), | ||
| html_div(id = "my-div2") do | ||
| html_h1("gggg", id = "my-h") | ||
| end | ||
| end | ||
| callback!(app, callid"{my-id.type} my-id.value => my-div.children, my-h.children") do state, value | ||
| return state, value | ||
| end | ||
| @test length(app.callbacks) == 1 | ||
| end | ||
|
|
||
| @testset "clientside callbacks function" begin | ||
| app = dash() | ||
| app.layout = html_div() do | ||
| dcc_input(id = "my-id", value="initial value", type = "text"), | ||
| html_div(id = "my-div") | ||
| end | ||
|
|
||
| callback!(ClientsideFunction("namespace", "func_name"),app, callid"my-id.value => my-div.children") | ||
|
|
||
| @test length(app.callbacks) == 1 | ||
| @test haskey(app.callbacks, Symbol("my-div.children")) | ||
| @test app.callbacks[Symbol("my-div.children")].func isa ClientsideFunction | ||
| @test app.callbacks[Symbol("my-div.children")].func.namespace == "namespace" | ||
| @test app.callbacks[Symbol("my-div.children")].func.function_name == "func_name" | ||
|
|
||
| @test_throws ErrorException callback!(app, callid"my-id.value => my-div.children") do value | ||
| return "v_$(value)" | ||
| end | ||
|
|
||
| handler = make_handler(app) | ||
| request = HTTP.Request("GET", "/_dash-dependencies") | ||
| resp = HTTP.handle(handler, request) | ||
| deps = JSON2.read(String(resp.body)) | ||
|
|
||
| @test length(deps) == 1 | ||
| cb = deps[1] | ||
| @test cb.output == "my-div.children" | ||
| @test cb.inputs[1].id == "my-id" | ||
| @test cb.inputs[1].property == "value" | ||
| @test :clientside_function in keys(cb) | ||
| @test cb.clientside_function.namespace == "namespace" | ||
| @test cb.clientside_function.function_name == "func_name" | ||
| end | ||
| @testset "clientside callbacks string" begin | ||
| app = dash() | ||
| app.layout = html_div() do | ||
| dcc_input(id = "my-id", value="initial value", type = "text"), | ||
| html_div(id = "my-div") | ||
| end | ||
|
|
||
| callback!( | ||
| """ | ||
| function(input_value) { | ||
| return ( | ||
| parseFloat(input_value_1, 10) | ||
| ); | ||
| } | ||
| """ | ||
| , app, callid"my-id.value => my-div.children" | ||
| ) | ||
|
|
||
| @test length(app.callbacks) == 1 | ||
| @test haskey(app.callbacks, Symbol("my-div.children")) | ||
| @test app.callbacks[Symbol("my-div.children")].func isa ClientsideFunction | ||
| @test app.callbacks[Symbol("my-div.children")].func.namespace == "_dashprivate_my-div" | ||
| @test app.callbacks[Symbol("my-div.children")].func.function_name == "children" | ||
| @test length(app.inline_scripts) == 1 | ||
| @test occursin("clientside[\"_dashprivate_my-div\"]", app.inline_scripts[1]) | ||
| @test occursin("ns[\"children\"]", app.inline_scripts[1]) | ||
|
|
||
| handler = make_handler(app) | ||
| request = HTTP.Request("GET", "/_dash-dependencies") | ||
| resp = HTTP.handle(handler, request) | ||
| deps = JSON2.read(String(resp.body)) | ||
|
|
||
| @test length(deps) == 1 | ||
| cb = deps[1] | ||
| @test cb.output == "my-div.children" | ||
| @test cb.inputs[1].id == "my-id" | ||
| @test cb.inputs[1].property == "value" | ||
| @test :clientside_function in keys(cb) | ||
| @test cb.clientside_function.namespace == "_dashprivate_my-div" | ||
| @test cb.clientside_function.function_name == "children" | ||
| request = HTTP.Request("GET", "/") | ||
| resp = HTTP.handle(handler, request) | ||
| body = String(resp.body) | ||
| @test occursin("clientside[\"_dashprivate_my-div\"]", body) | ||
| @test occursin("ns[\"children\"]", body) | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me exactly what's being tested by some of these
@test_throws- at a minimum it would be nice to have a comment like "my-div2.children is already an output", but better would be for the code to somehow inspect the error to ensure it's actually the one you intended to be thrown, as opposed to something else like a typo in thecallidstring causing a regexp failure.Minor, and not new in this PR, you're just rearranging, but it's the first I'm looking at this code 😉