Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to angular10 #128

Merged
merged 13 commits into from
Aug 21, 2020
Merged

Migrating to angular10 #128

merged 13 commits into from
Aug 21, 2020

Conversation

andrefarzat
Copy link
Collaborator

Closes #120

@coveralls
Copy link

coveralls commented Aug 21, 2020

Pull Request Test Coverage Report for Build 00385725-d187-4a7f-a37d-dce6dd045fd7

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 95.714%

Totals Coverage Status
Change from base Build 178: 1.0%
Covered Lines: 46
Relevant Lines: 46

💛 - Coveralls

@andrefarzat andrefarzat merged commit bdc1e5b into master Aug 21, 2020
@andrefarzat andrefarzat deleted the angular10 branch August 21, 2020 01:26
@MHC2000
Copy link

MHC2000 commented Aug 26, 2020

Hi there,

it looks like the version 3.0.0 isn't published to npm. Is there a reason for this?

Regards

@andrefarzat
Copy link
Collaborator Author

@MHC2000 sorry for this confusion, we were testing the new code in angular 10 and publishing it with the new angular library schema. Everything should be fine now 😸

@MHC2000
Copy link

MHC2000 commented Aug 27, 2020

@andrefarzat perfect thanks, it works now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Angular 10
4 participants