Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to dash 1.0, plus R build #75

Merged
merged 8 commits into from
Aug 6, 2019
Merged

update to dash 1.0, plus R build #75

merged 8 commits into from
Aug 6, 2019

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Jun 28, 2019

closes #29
Updates tests here to use dash.testing, and more standardized build commands.

Adding R support turned out to be a lot simpler than #72 made it look - basically, adding in r_prefix and using it in the dash-generate-components call means it all just works ™️ - I added some tests that the right files (R and otherwise) are present after building.

This is ready for review, but should not be merged until plotly/dash#801 is merged and released so we can point to a released version of dash in the various requirements.txt files.

@bcliang
Copy link

bcliang commented Jul 2, 2019

Please consider updating package.json with upgraded devDependency eslint to 5.16.0. The main thing here is that it closes a vulnerability in js-yaml@3.13.0

  "devDependencies": {
...
    "eslint": "^5.16.0",
...
  },

@alexcjohnson
Copy link
Collaborator Author

Please consider updating package.json with upgraded devDependency eslint to 5.16.0

Now eslint is up to v6. Updated all of package.json, and the necessary dash changes have been released so we use that as well. @byronz ready for review.

@@ -1,4 +1,3 @@
dash==0.38.0
dash[testing]>=1.0.2
pytest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to have pytest relevant dependencies here as dash[testing] will control that

@@ -3,10 +3,9 @@
# pip install -r requirements.txt

chromedriver-binary
dash>=0.38.0
dash[testing]>=1.0.2
ipdb
percy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: percy adn selenium will be installed by dash[testing]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For that matter I don't know why we need anything other than dash[testing]... none of our other repos require chromedriver-binary, and I don't see ipdb, flake8, or pylint used - do you see any reason we should keep those?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not needed, I'm fine to 🔪

Copy link

@byronz byronz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit 928d8e7 into master Aug 6, 2019
@alexcjohnson alexcjohnson deleted the dash-testing branch August 6, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boilerplate should include R component metadata
3 participants