Initial commit of R packaging-related files for dash-component-boilerplate #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,8 +10,9 @@ | |||
| "build:js-dev": "webpack --mode development", | |||
| "build:js": "webpack --mode production", | |||
| "build:py": "dash-generate-components ./src/lib/components {{ cookiecutter.project_shortname }}", | |||
| "build:r": "dash-generate-components ./src/lib/components {{ cookiecutter.project_shortname }} --r-prefix '{{ cookiecutter.r_package_prefix }}'", | |||
There was a problem hiding this comment.
As in plotly/dash-core-components#555 let's change this to a single back-end command build:py_and_r, also using -p package-info.json.
Do the build commands fail if the directories are missing entirely, ie they need to be created during build? If you really need to have something, perhaps an empty |
|
As discussed with @rpkyle I'm currently updating this repo for dash 1.0 - will include R support there, based on the work in this PR. I'll keep this PR open though until the new one is ready. |
|
Closing in favor of #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29.
There are some stub files here, namely in
Randman, since I'm not sure how to commit the empty directories to the repo otherwise.