Fix start script #77
Merged
Fix start script #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Good catch @LuAPi - it wouldn't work with the other src, and though webpack-serve does seem to work without the --config it's clearly the correct usage. 💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run
npm run startand found the webpage didn't work. It seems that webpack-serve needs to have a --config flag set in order for it to look at the file it is provided with. The dev version of the built file appears in a subdirectory instead of the root directory so I updated the index.html to point at the right place.Unrelated to the PR: After running cookie cutter I had to manually
npm install http2to makenpm run startwork (using node 8.4.0).