Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Fix nested data for the Store component. #333

Merged
merged 6 commits into from
Oct 17, 2018
Merged

Fix nested data for the Store component. #333

merged 6 commits into from
Oct 17, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Oct 16, 2018

Recursively check the data contained in arrays and objects to look for changes.

Fixes #332.

  • add nested data integration test.

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Oct 16, 2018

@valentijnnieman
Circleci fail with a strange error on build python 2.7, think we need to unpin chardet dependencies.

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Oct 16, 2018

Resolved the python 2.7 build by pinning urllib3<=1.22

psf/requests#4673

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Oct 17, 2018

@valentijnnieman please review, this fixes a new bug in 2.7 tests and the store component.

@T4rk1n T4rk1n merged commit b923e23 into master Oct 17, 2018
@T4rk1n T4rk1n deleted the store-nested-data branch October 17, 2018 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants