Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested data for the Store component. #333

Merged
merged 6 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@T4rk1n
Copy link
Contributor

commented Oct 16, 2018

Recursively check the data contained in arrays and objects to look for changes.

Fixes #332.

  • add nested data integration test.
@T4rk1n

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

@valentijnnieman
Circleci fail with a strange error on build python 2.7, think we need to unpin chardet dependencies.

@T4rk1n

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

Resolved the python 2.7 build by pinning urllib3<=1.22

kennethreitz/requests#4673

@T4rk1n T4rk1n requested a review from valentijnnieman Oct 16, 2018

@T4rk1n

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

@valentijnnieman please review, this fixes a new bug in 2.7 tests and the store component.

@T4rk1n T4rk1n referenced this pull request Oct 17, 2018

Closed

Document the dcc.Store #213

valentijnnieman added a commit that referenced this pull request Oct 17, 2018

@T4rk1n T4rk1n merged commit b923e23 into master Oct 17, 2018

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review approved by Philippe Duval
Details

@T4rk1n T4rk1n deleted the store-nested-data branch Oct 17, 2018

@T4rk1n T4rk1n referenced this pull request Oct 18, 2018

Closed

urllib3 update broke CI #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.