Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plotly.js to 1.42.1 #354

Merged
merged 4 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@T4rk1n
Copy link
Contributor

commented Oct 31, 2018

I made sure the local file and external file are the same by doing wget https://cdn.plot.ly/plotly-1.42.1.min.js for the local file.

@@ -2,7 +2,7 @@ node_modules/
.npm
.git/
vv/
venv/
venv*

This comment has been minimized.

Copy link
@T4rk1n

T4rk1n Oct 31, 2018

Author Contributor

I use venv36 for testing on python 3 and venv for python 2, was doing a release the other time and noticed the package was over 130mb because it took the venv36 files, that package was canceled before upload.

@T4rk1n

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

@valentijnnieman please review.

There's 13 visuals diffs, I think an icon got added in the graph ?

@T4rk1n T4rk1n requested a review from valentijnnieman Oct 31, 2018

@@ -1,6 +1,6 @@
{
"name": "dash-core-components",
"version": "0.35.2",
"version": "0.35.3",

This comment has been minimized.

Copy link
@chriddyp

chriddyp Oct 31, 2018

Member

I like to do minor version updates (e.g. to 0.36.0) since from the users perspective, this version update adds many new features to the dcc.Graph component.

@T4rk1n T4rk1n force-pushed the update-plotlyjs branch from ad3118c to 20fdfd8 Oct 31, 2018

@valentijnnieman
Copy link
Contributor

left a comment

💃 if the changelog is updated! And yeah, it looks like a new icon was added to plotly.js.

- Updated plotly.js to 1.42.1 [#354](https://github.com/plotly/dash-core-components/pull/354)
- https://github.com/plotly/plotly.js/releases/tag/v1.42.0
- https://github.com/plotly/plotly.js/releases/tag/v1.42.1

This comment has been minimized.

Copy link
@valentijnnieman

valentijnnieman Oct 31, 2018

Contributor

We usually copy over the changelog from plotly.js here, check out other updates that included plotly.js releases below, it should look similar to that.

@chriddyp

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

@T4rk1n T4rk1n merged commit 5bddcfd into master Nov 1, 2018

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review approved by Philippe Duval
Details

@T4rk1n T4rk1n deleted the update-plotlyjs branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.