This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Issue 404 - Add source map to package #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- expose map files (dynamic) - update changelog
Marc-Andre-Rivet
commented
Dec 7, 2018
| '/dash_core_components/dash_core_components.min.js.map' | ||
| ).format(__version__), | ||
| 'namespace': 'dash_core_components', | ||
| 'dynamic': True |
There was a problem hiding this comment.
Expose the map files, make them dynamic
Marc-Andre-Rivet
commented
Dec 7, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "dash-core-components", | |||
| "version": "0.40.2", | |||
| "version": "0.40.3", | |||
There was a problem hiding this comment.
bump version
Marc-Andre-Rivet
commented
Dec 7, 2018
| const devtool = overrides.devtool || ( | ||
| mode === 'development' ? "eval-source-map" : 'none' | ||
| ); | ||
| const devtool = overrides.devtool || 'source-map'; |
There was a problem hiding this comment.
default to source-map now -- this causes the dev bundle to increase dramatically in number of lines, even if it is smaller now -- same issue as with plotly/dash-renderer#105 (comment)
valentijnnieman
approved these changes
Dec 7, 2018
|
Still need to figure out why that one percy test is failing reliably. |
|
Oops, you're right. |
|
The snapshot is too soon after starting the server, add a time.sleep between those lines: dash-core-components/test/test_integration.py Lines 817 to 819 in 19ac349 |
|
Ok. Will try that and force re-run it a few times. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
Relates to plotly/dash#478
plotly/dash-renderer#104
Relates to plotly/dash-table#284