This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Fix store null values in lists #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💃 |
src/components/Store.react.js
Outdated
| if (R.isNil(old) || R.isNil(data)) { | ||
| const oldNull = R.isNil(old); | ||
| const newNull = R.isNil(data); | ||
| if ((oldNull || newNull) && !(oldNull && newNull)) { |
There was a problem hiding this comment.
I found this a bit hard to read... how about if (oldNull !== newNull) ? Or I suppose you could short-circuit the logic below with something like if (oldNull || newNull) { return oldNull !== newNull; }
Separately, it looks to me as though the checks below implicitly assume old and data have the same type, and may fail if for example data is an Array and old is an Object. Should we include a step if (R.type(old) !== type) { return false; }?
There was a problem hiding this comment.
Separately, it looks to me as though the checks below implicitly assume old and data
That's the second part of #422, I'll add a test and fix it in another PR. Initial implementation assumed data was of the same shape.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that both old and new data is not null when checking if the data needs update.
Part of fix for #422.
@rmarren1 please review.