Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified Graph.react.js to include restyle event #483

Merged
merged 9 commits into from Mar 18, 2019
Merged

Modified Graph.react.js to include restyle event #483

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6be39e7
Modified Graph.react.js to include restyle event
mako-npm Mar 8, 2019
8638098
prettier
alexcjohnson Mar 14, 2019
b3a2634
remove unused/duplicate imports in integration tests
alexcjohnson Mar 14, 2019
b640e63
test graph restyle/relayout events and rebuild
alexcjohnson Mar 14, 2019
7cf7589
Merge branch 'master' into Add_restyle_prop
alexcjohnson Mar 14, 2019
e6d2830
fix graph data test
alexcjohnson Mar 14, 2019
f605230
robustify percy tests
alexcjohnson Mar 15, 2019
8e7806b
:hocho: `setProps` conditional from new `restyleData`
alexcjohnson Mar 16, 2019
688a66f
fix restyleData propType, and improve prop docs
alexcjohnson Mar 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/test_integration.py
View file
Open in desktop
Expand Up @@ -640,7 +640,11 @@ def on_click(n_clicks):
'x': [1, 2, 3, 4],
'y': [4, 3, 2, 1]
}
]
],
'layout': {
'width': 700,
'height': 450
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to say about this one... I'm tempted to consider it a bug, but I don't know what we'd do to fix it. The issue - and I still don't understand why it's triggered intermittently here, but it's a real issue users will face - is that if you have an autosized graph that's initially drawn in a display: none container, it gets the default size. It keeps that default size when the container is displayed, because no redraw is triggered. But if the window is resized at all, THEN the graph gets sized correctly.

This seems to sometimes happen on CI - see eg https://percy.io/plotly/dash-core-components/builds/1576352?utm_campaign=plotly&utm_content=dash-core-components&utm_source=github_status - so I'm just locking down the size here.

}

self.startServer(app=app)
Expand Down Expand Up @@ -1196,8 +1200,8 @@ def _on_confirmed(submit_n_clicks, cancel_n_clicks,
return 'canceled'

self.startServer(app)
self.snapshot(test_name + ' -> initial')
button = self.wait_for_element_by_css_selector('#button')
self.snapshot(test_name + ' -> initial')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take the snapshot after we know the button exists


button.click()
time.sleep(1)
Expand Down