Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove graph config innards from defaultProps #515

Merged
merged 7 commits into from Apr 9, 2019
Merged

Remove graph config innards from defaultProps #515

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3521da0
remove Graph.defaultProps.config innards
alexcjohnson Apr 9, 2019
9e8f451
rebuild
alexcjohnson Apr 9, 2019
d4df7cc
changelog entry for graph config fix
alexcjohnson Apr 9, 2019
071b11c
fix format
Apr 9, 2019
55f45d2
test some stuff about plotly.js vs Graph
alexcjohnson Apr 9, 2019
970c682
lint
alexcjohnson Apr 9, 2019
802a9c0
capitalize some propTypes docstrings - and add one missing one
alexcjohnson Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Graph.react.js
View file
Open in desktop
Expand Up @@ -557,7 +557,7 @@ const graphPropTypes = {
* Extra resolution to give the file after
* rendering it with the given width and height
*/
scale: PropTypes.number
scale: PropTypes.number,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks. I had done that locally but hadn't pushed it yet as I'm adding a couple of tests.

}),

/**
Expand Down