Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Plotly.js to 1.47.0 #516

Merged
merged 8 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@Marc-Andre-Rivet
Copy link
Contributor

commented Apr 9, 2019

  • missing 1.47.0 and 1.46.0 feature release highlights

Marc-André Rivet and others added some commits Apr 9, 2019

Marc-André Rivet
2. Update `dash_core_components/__init__.py` plotly.js `external_url`
3. Update `MANIFEST.in`

This comment has been minimized.

Copy link
@Marc-Andre-Rivet

Marc-Andre-Rivet Apr 9, 2019

Author Contributor

Updated manifest to use wildcard, this step is no longer required

@@ -5,7 +5,7 @@ include dash_core_components/dash_core_components.dev.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/plotly-1.45.0.min.js
include dash_core_components/plotly-*.min.js

This comment has been minimized.

Copy link
@Marc-Andre-Rivet

@Marc-Andre-Rivet Marc-Andre-Rivet requested a review from alexcjohnson Apr 9, 2019

@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review Apr 9, 2019

Marc-Andre-Rivet and others added some commits Apr 9, 2019

@alexcjohnson
Copy link
Contributor

left a comment

I just tweaked the changelog a tiny bit. Looks good! 💃

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

kinda weird percy diffs - just a bunch of new whitespace at the bottom of the page. I'm going to guess it's just percy doing something weird with the extra internal structure of a plotly.js graph added in plotly/plotly.js#3589... looks fine locally, I approved the diff.

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit f90f80c into master Apr 9, 2019

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review approved by Marc-André Rivet
Details

@Marc-Andre-Rivet Marc-Andre-Rivet deleted the plotlyjs-1.47.0 branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.