Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Ronniebugia fixing checklist #550

Closed

Conversation

ronniebugia
Copy link

@ronniebugia ronniebugia commented May 9, 2019

There was an issue regarding the Checklist.react.js component. There was no default value specified for the values attribute. If you have a dash app with a dcc.Checklist() and did not specify a value for the values attribute, you would have gotten an error that says error loading layout .

@Marc-Andre-Rivet
Copy link
Contributor

Marc-Andre-Rivet commented May 10, 2019

@ronniebugia Thanks for finding this. We'll need a few more things to make this PR complete:

  1. Backpedal the fix, add a test that fails without it (commit + CI build) followed by the fix and the test now passing (commit + CI build) -- this test should be in test_integration.py and be an isolated test (e.g. test_vertical_range_slider) with a snapshot and a browser log check at the end

  2. Add a CHANGELOG unreleased ###Fixed entry that refers to this PR

Let me know if you need more info to get you going.

@Marc-Andre-Rivet Marc-Andre-Rivet self-requested a review May 10, 2019 14:19
@alexcjohnson
Copy link
Collaborator

Closing - the default was added while renaming values to value in #558

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants