Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Dropdown to accept optionHeight prop #552

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@mmartinsky
Copy link
Contributor

commented May 10, 2019

#544

Add the ability to set the optionHeight of the react-virtualized-select options. This is useful if you have labels that are too long to fit on a single line, but don't want the options to overlap.

New, using optionHeight={50}
image

Old/Default:
image

@alexcjohnson
Copy link
Contributor

left a comment

Thanks @mmartinsky - this will be helpful. (For the sake of others reading this, I'll note that 35 is the default from the underlying component https://github.com/bvaughn/react-virtualized-select. It makes sense to list this explicitly here so people know the baseline against which to provide a different value)

@alexcjohnson alexcjohnson merged commit 0fc7e15 into plotly:master May 10, 2019

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review approved by johnson.alex.c@gmail.com
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.