Fix tab disabled issue #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2019 17:45
| @@ -7,8 +7,9 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| - Ability to add tooltips to `Slider` and `RangeSlider`, which can be visible always or on hover. Tooltips also take a position argument. [#564](https://github.com/plotly/dash-core-components/pull/564) | |||
|
|
|||
| ### Fixed | |||
| - Fixed `min_date_allowed` and `max_date_allowed` bug in `DatePickerRange` [#551]https://github.com/plotly/dash-core-components/issues/551) | |||
| - Fixed `min_date_allowed` and `max_date_allowed` bug in `DatePickerRange` [#551](https://github.com/plotly/dash-core-components/issues/551) | |||
There was a problem hiding this comment.
Yeah, I thought I fixed it, must be.
alexcjohnson
approved these changes
Jun 13, 2019
Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
|
Hmm, not sure why percy isn't picking up this job. Would it need write access to the source repo? Merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue occurring in the Tab component when disabled and styled with custom CSS classes.
The
tab--disabledCSS class was appended to the component className without an initial space and was concatenated to the last custom CSS class if provided, consequently breaking the styling.I had also a simple test to check if the disabled Tab component is findable by the
tab--disabledCSS class.It's my first PR, let me know if it's okay or if I have to do something more.