Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

603 graph cleanup #604

Merged
merged 4 commits into from
Aug 14, 2019
Merged

603 graph cleanup #604

merged 4 commits into from
Aug 14, 2019

Conversation

alexcjohnson
Copy link
Collaborator

Fixes #603

Cleans up properly when a Graph is unmounted, and stops creating random IDs when no ID is provided - instead using a ref to connect directly to the DOM element.

@alexcjohnson alexcjohnson mentioned this pull request Aug 14, 2019
Closed
byronz
byronz approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@byronz byronz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 this fixes the reported issue, we can do another PR for the infinite loop. merge this before I do the dev switch

@alexcjohnson alexcjohnson merged commit 5ed92d7 into master Aug 14, 2019
@alexcjohnson alexcjohnson deleted the 603-graph-cleanup branch August 14, 2019 19:24
@bcliang bcliang mentioned this pull request Aug 28, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@byronz byronz byronz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph overdrawing & failed cleanup
2 participants
@alexcjohnson @byronz