This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Use new @plotly/dash-component-plugins to handle location path changes #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents - use component plugins to emit global event from location component
src/components/Link.react.js
Outdated
| @@ -47,7 +47,7 @@ export default class Link extends Component { | |||
| window.location.pathname = href; | |||
| } else { | |||
| window.history.pushState({}, '', href); | |||
| window.dispatchEvent(new CustomEvent('onpushstate')); | |||
| window.dispatchEvent(new CustomEvent('_dashprivate_onpushstate')); | |||
There was a problem hiding this comment.
Make the link <--> location event explicitly private. No one outside of DCC should listen to this.
| window.addEventListener( | ||
| '_dashprivate_onpushstate', | ||
| this.onLocationChange | ||
| ); |
There was a problem hiding this comment.
Location triggers a location changed event on both (1) click on dcc.Link with refresh=false (default), (2) user clicking back and forward buttons in the browser UI. Prior to this change it was only possible to listen for (1) with "onpushstate"
There was a problem hiding this comment.
nice
the location history feature is working well
wbrgss
approved these changes
Jan 29, 2020
| window.addEventListener( | ||
| '_dashprivate_onpushstate', | ||
| this.onLocationChange | ||
| ); |
There was a problem hiding this comment.
nice
the location history feature is working well
| ) | ||
|
|
||
| assert link_counter == 1 | ||
| assert history_counter == 1 |
There was a problem hiding this comment.
Simple test making sure the events are being triggered by the components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to plotly/dash#1094