This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Added title prop to dcc.Link #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadTheOne
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
|
@HammadTheOne The linting errors can be fixed by running |
Marc-Andre-Rivet
suggested changes
Mar 11, 2020
There was a problem hiding this comment.
- As mentioned in the previous comment, make sure
npm run lintandnpm run formatdon't return errors. - Need to add a changelog entry
- Needs a simple test (eg. making sure that the
titleis present in the DOM -- check outget_attribute(...)in the tests and https://github.com/plotly/dash-core-components/blob/dev/tests/integration/link/test_link_event.py for a starting point testing links)
3 tasks
Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
| ''' | ||
| return document.getElementById("link1").getAttribute("title"); | ||
| ''' | ||
| ) |
There was a problem hiding this comment.
Does this work instead?
dash_dcc.find_element('#link1').get_attribute('title')
There was a problem hiding this comment.
Added in f80f844. This works, thank you for the suggestion.
|
|
Marc-Andre-Rivet
approved these changes
Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the title property to dcc.Link, bringing it more into line with what is expected of a html style link component. The title attribute of the link allows you to add supplementary information to a hyperlink which appears when mouse-hovering over it.
Adding as part of feature request in #586 .
Closes #586 .