Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for min gauge values > 0 #170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rolandFleddermann
Copy link

The color locations were off before when the minimum value of a gauge scale was set to a value > 0.

for example in this case

Gauge( id="demoGauge", label="Gauge", logarithmic=False, min=50, max=150, scale={"start": 50, "interval": 10, "labelInterval": 10}, value=100, showCurrentValue=True, color={"gradient": False, "default": "lightblue", "ranges": {"red": [50, 100], "yellow": [100, 110],"green": [110, 150]}} ),

before the fix it would render like this:

before:
image

and after:
image

Unfortunately the diff does not render all that well, all that happened is that I removed the
if (minimum < 0) {
block and changed the indent level inside...

The color locations were off before when the minimum value of a gauge scale was set to a value > 0.
@alexcjohnson
Copy link
Collaborator

Thanks @rolandFleddermann - and apologies that we haven't gotten a chance to review this yet. This repo has had a whole bunch of work added to it a while back that we haven't had a chance yet to QA and release, but I'm hoping we can get to that in the next couple of months!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants