Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

missing some attributes for Iframe? #77

Closed
chriddyp opened this issue Nov 2, 2018 · 6 comments · Fixed by #179
Closed

missing some attributes for Iframe? #77

chriddyp opened this issue Nov 2, 2018 · 6 comments · Fixed by #179

Comments

@chriddyp
Copy link
Member

chriddyp commented Nov 2, 2018

  • frameborder
  • scrolling
@oxydaemon
Copy link

Also missing "allow" attribute

(https://community.plot.ly/t/using-keywords-in-dash-iframe/13485)

@HungYuHeng
Copy link

Missing "allowfullscreen" attribute,too.

@Martiix
Copy link

Martiix commented Jan 5, 2020

autoplay (allow) and loop attribute would be nice.

@chriddyp
Copy link
Member Author

chriddyp commented Jan 6, 2020

Until these are available, one solution would be to use

    dash_dangerously_set_inner_html.DangerouslySetInnerHTML('''
        <iframe ...
    '''),

as per https://github.com/plotly/dash-dangerously-set-inner-html

This is still a good issue and one worth fixing.

@cassova
Copy link

cassova commented Feb 3, 2021

Are there any updates on supporting features like the allowFullScreen for embedded youtube videos?

@alexcjohnson
Copy link
Collaborator

This hasn't bubbled up to the top of the list for anyone at Plotly yet, but we'd be happy to review a PR!

AnnMarieW pushed a commit to AnnMarieW/dash-html-components that referenced this issue Feb 11, 2021
rpkyle added a commit that referenced this issue Apr 8, 2021
* Use authenticated Docker pulls (#167)

* Update CODEOWNERS

* Bump dot-prop from 4.2.0 to 4.2.1

Bumps [dot-prop](https://github.com/sindresorhus/dot-prop) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/sindresorhus/dot-prop/releases)
- [Commits](sindresorhus/dot-prop@v4.2.0...v4.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

* improve dash import test
see plotly/dash#1143

* changelog for import bug fix

* update extract-attributes script for latest MDN page structure
and provide an error message if we see the page structure change
in the future

* description for setProps - to reduce warnings

* use dash loosen-testing-reqs branch and fix linting

* Fix spelling

* back to dev branch of dash

* bump ci images versions

* Update config.yml

* update component gen for MDN update Jan 2021

* error message if element count changes from expectation

* add reference to MDN PR with the math & svg addition

* bump to v1.1.2 (#176)

* Remove context reference from CircleCI (#175)

* fix ObjectEl data prop

* add deprecation notes on some elements, and fix for a few more changes to MDN

* update tests, and add tests for custom docs and ObjectEl

* move percy to py37 and separate out finalize step

* more test cleanup

* one more try to combine percy snapshots

* changelog for #178

* Add `allow` prop to html.Iframe

* Add `referrerPolicy` prop and update tests

* Add `referrerPolicy` prop and update tests

* Updated changelog  Fixes #77

* Update CHANGELOG.md

* Bump elliptic from 6.5.3 to 6.5.4

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

* update toolchain

* Update CI images & py37 -> py39

* Bump y18n from 4.0.0 to 4.0.1

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

* remove css

* version bump 1.1.3 (#184)

* version bump to 1.1.3

* update changelog

* artifacts

Co-authored-by: Ryan Patrick Kyle <rpkyle@users.noreply.github.com>
Co-authored-by: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: alexcjohnson <alex@plot.ly>
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
Co-authored-by: John Bampton <jbampton@gmail.com>
Co-authored-by: Marc-André Rivet <marc-andre.rivet@plotly.com>
Co-authored-by: Ann Marie Ward <amward@fastmail.us>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants