This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Upgrade to React 16 #145
Merged
Upgrade to React 16 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Andre-Rivet
commented
Apr 4, 2019
| @@ -39,7 +39,7 @@ jobs: | |||
| name: Install dependencies (dash) | |||
| command: | | |||
| git clone git@github.com:plotly/dash.git | |||
| git clone git@github.com:plotly/dash-core-components.git | |||
| git clone -b react-16 git@github.com:plotly/dash-core-components.git | |||
There was a problem hiding this comment.
To be removed after master merge
Marc-Andre-Rivet
commented
Apr 4, 2019
| ? {errorLoading} | ||
| : null | ||
| ); | ||
| } |
There was a problem hiding this comment.
React 16 component render differs greatly from React 15 in terms of error handling. MultiGraph.overallOrder() called by hydrateInitialOutputs throws an error when there is a cycle. This error needs to be caught and handled, otherwise the entire app fails to render.
Marc-Andre-Rivet
commented
Apr 4, 2019
| ], | ||
| 'relative_package_path': [ | ||
| 'react@16.2.0.production.min.js', | ||
| 'react-dom@16.2.0.production.min.js' |
There was a problem hiding this comment.
Remove test relative to 15.4.2
Marc-Andre-Rivet
commented
Apr 4, 2019
| _REACT_VERSION_TO_URLS = { | ||
| '15.4.2': { | ||
| '16.8.6': { |
There was a problem hiding this comment.
fwiw, no need to update the manifest as it wildcards react and react-dom versions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcc sibling: plotly/dash-core-components#508