Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Upgrade to React 16 #145

Merged
merged 17 commits into from
Apr 9, 2019
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
name: Install dependencies (dash)
command: |
git clone git@github.com:plotly/dash.git
git clone git@github.com:plotly/dash-core-components.git
git clone -b react-16 git@github.com:plotly/dash-core-components.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed after master merge

git clone git@github.com:plotly/dash-html-components.git
git clone git@github.com:plotly/dash-table.git
. venv/bin/activate
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Changed
[#145](https://github.com/plotly/dash-renderer/pull/145)
- Update from React 15.4.2 to React 16.8.6

### Removed
- `dash_renderer._set_react_version` support for 15.4.2 and 16.2.0

## [0.21.0] - 2019-03-25
### Changed
[#140](https://github.com/plotly/dash-renderer/pull/140)
Expand Down
27 changes: 7 additions & 20 deletions dash_renderer/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,17 @@
from .version import __version__
__file__

_DEFAULT_REACT_VERSION = '15.4.2'
_REACT_VERSION_TYPES = {'15.4.2', '16.2.0'}
_DEFAULT_REACT_VERSION = '16.8.6'
_REACT_VERSION_TYPES = {'16.8.6'}
_REACT_VERSION_TO_URLS = {
'15.4.2': {
'16.8.6': {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, no need to update the manifest as it wildcards react and react-dom versions

'external_url': [
'https://unpkg.com/react@15.4.2/dist/react.min.js',
'https://unpkg.com/react-dom@15.4.2/dist/react-dom.min.js'
'https://unpkg.com/react@16.8.6/umd/react.production.min.js',
'https://unpkg.com/react-dom@16.8.6/umd/react-dom.production.min.js'
],
'relative_package_path': [
'react@15.4.2.min.js',
'react-dom@15.4.2.min.js'
],
},
'16.2.0': {
'external_url': [
'https://unpkg.com/react@16.2.0/umd/react.production.min.js',
'https://unpkg.com/react-dom@16.2.0/umd/react-dom.production.min.js'
],
'relative_package_path': [
'react@16.2.0.production.min.js',
'react-dom@16.2.0.production.min.js'
'react@16.8.6.min.js',
'react-dom@16.8.6.min.js'
],
}
}
Expand All @@ -46,9 +36,6 @@ def _set_react_version(react_version):
```
import dash_renderer

# Set the react version before setting up the Dash application
dash_renderer._set_react_version('16.2.0')

app = dash.Dash(...)
```

Expand Down
15 changes: 0 additions & 15 deletions dash_renderer/react-dom@15.4.2.min.js

This file was deleted.

193 changes: 0 additions & 193 deletions dash_renderer/react-dom@16.2.0.production.min.js

This file was deleted.

220 changes: 220 additions & 0 deletions dash_renderer/react-dom@16.8.6.min.js

Large diffs are not rendered by default.

12 changes: 0 additions & 12 deletions dash_renderer/react@15.4.2.min.js

This file was deleted.

21 changes: 0 additions & 21 deletions dash_renderer/react@16.2.0.production.min.js

This file was deleted.

Loading