Issue148 - 0 children regression in dash==0.40.0
#150
Conversation
| @@ -33,7 +33,7 @@ const createContainer = component => isSimpleComponent(component) ? | |||
|
|
|||
| class TreeContainer extends Component { | |||
| getChildren(components) { | |||
| if (!components) { | |||
| if (isNil(components)) { | |||
There was a problem hiding this comment.
0 is falsy..
| @@ -475,6 +475,32 @@ def test_initial_state(self): | |||
|
|
|||
| assert_clean_console(self) | |||
|
|
|||
| def test_array_of_nully_child(self): | |||
| app = Dash(__name__) | |||
| app.layout = html.Div(id='nully-wrapper', children=[0]) | |||
There was a problem hiding this comment.
This worked and needs to keep working
There was a problem hiding this comment.
nice. I'd call this falsy though, not nully.
There was a problem hiding this comment.
good point
|
|
||
| def test_of_nully_child(self): | ||
| app = Dash(__name__) | ||
| app.layout = html.Div(id='nully-wrapper', children=0) |
There was a problem hiding this comment.
This is the regression case
There was a problem hiding this comment.
too late for the comment, but this should be merged with the test_initial_state.
Marc-Andre-Rivet
changed the title
0 children regression0 children regression in dash==0.40.0
| @@ -104,7 +104,7 @@ def request_queue_assertions( | |||
|
|
|||
| if expected_length is not None: | |||
| self.assertEqual(len(request_queue), expected_length) | |||
|
|
|||
There was a problem hiding this comment.
Oh noes, trailing whitespace courtesy of @chriddyp ??? 😅
tests/test_render.py
Outdated
| self.wait_for_element_by_css_selector('#nully-wrapper') | ||
| wrapper = self.driver.find_element_by_id('nully-wrapper') | ||
|
|
||
| self.assertEqual(wrapper.get_attribute('innerHTML'), '0') |
There was a problem hiding this comment.
Can't this whole section just be self.wait_for_text_to_equal('#nully-wrapper', '0')?
There was a problem hiding this comment.
Hum.. wasn't aware of that one. Looks like wait_for_text_to_equal uses value and that would mean it's only meant to be used with <input /> elements.
There was a problem hiding this comment.
value or .text:
dash-renderer/tests/test_render.py
Line 63 in 2c0169c
There was a problem hiding this comment.
Embarrassing. I can't read code it seems. Will update to use suggested.
FIxes #148.
Found the issue in dash-docs percy deltas in https://percy.io/plotly/dash-docs/builds/1719186
Add test for array case
children=[0], this passes with the existing code: 0602a15Add test for non-array case
children=0, this fails with the existing code: d48e81dFix: b600b8c