-
Notifications
You must be signed in to change notification settings - Fork 33
Issue148 - 0
children regression in dash==0.40.0
#150
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,7 +104,7 @@ def request_queue_assertions( | |
|
||
if expected_length is not None: | ||
self.assertEqual(len(request_queue), expected_length) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh noes, trailing whitespace courtesy of @chriddyp ??? 😅 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no way!! 🙊 🙊 🙊 |
||
|
||
def test_initial_state(self): | ||
app = Dash(__name__) | ||
app.layout = html.Div([ | ||
|
@@ -475,6 +475,26 @@ def test_initial_state(self): | |
|
||
assert_clean_console(self) | ||
|
||
def test_array_of_falsy_child(self): | ||
app = Dash(__name__) | ||
app.layout = html.Div(id='nully-wrapper', children=[0]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This worked and needs to keep working There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice. I'd call this falsy though, not nully. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good point |
||
|
||
self.startServer(app) | ||
|
||
self.wait_for_text_to_equal('#nully-wrapper', '0') | ||
|
||
assert_clean_console(self) | ||
|
||
def test_of_falsy_child(self): | ||
app = Dash(__name__) | ||
app.layout = html.Div(id='nully-wrapper', children=0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the regression case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. too late for the comment, but this should be merged with the |
||
|
||
self.startServer(app) | ||
|
||
self.wait_for_text_to_equal('#nully-wrapper', '0') | ||
|
||
assert_clean_console(self) | ||
|
||
def test_simple_callback(self): | ||
app = Dash(__name__) | ||
app.layout = html.Div([ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 is falsy..