This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
fix dropdown regression + test #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +128,7 @@ export default class CellFactory { | |||
| } | |||
| } | |||
|
|
|||
| private handleChange = (idx: number, i: number, e: any) => { | |||
| private handleChange = (idx: number, i: number, value: any) => { | |||
There was a problem hiding this comment.
Doing away with the event wrapper, it served no purpose at this point
| DashTable.getCell(0, 8).within(() => { | ||
| cy.get('.Select-value-label').should('have.html', expectedValue); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Click on a cell with dropdown, check current value, select a different value, make sure it's applied.
| @@ -45,11 +45,13 @@ export default class ControlledTable extends Component<ControlledTableProps> { | |||
|
|
|||
| // Fallback method for paste handling in Chrome | |||
| // when no input element has focused inside the table | |||
| window.addEventListener('resize', this.handleResize); | |||
There was a problem hiding this comment.
Zoom triggers a resize event, so does resizing the window/browser.. but that's the best we have access to.
added 2 commits
September 11, 2018 14:35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix dropdown behavior on click (saves selection)
additional test for dropdown
fix border style on active cell
resize on zoom change