Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making adjustments for building dash on a windows machine #2752

Merged
merged 71 commits into from Feb 14, 2024

Conversation

BSd3v
Copy link
Contributor

@BSd3v BSd3v commented Feb 7, 2024

This PR is an attempt to ease the build process when using a windows machine:

This build still uses git bash to execute the scripts and the build:

  • using rimraf instead of rm for removing files/directories.
  • using mkdirp instead of mkdir -p
  • update_components:
    • windows kept the ' which threw off the all test.
    • print even with unicode errors
    • dest_dir_map to map components to directories instead of if statement
    • altered the pipe delimited for {} with comma delimited (error with any second+ component)
  • added new script first-build that will create html components and npm i for the dash-renderer

@Coding-with-Adam
Copy link

Thank you for this PR, @BSd3v .

BSd3v and others added 4 commits February 13, 2024 17:32
Co-authored-by: Alex Johnson <alex@plot.ly>
Co-authored-by: Alex Johnson <alex@plot.ly>
Co-authored-by: Alex Johnson <alex@plot.ly>
Co-authored-by: Alex Johnson <alex@plot.ly>
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 That was a slog, thanks for pushing it through @BSd3v!

@alexcjohnson alexcjohnson merged commit 6051319 into plotly:dev Feb 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants