Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making adjustments for building dash on a windows machine #2752

Merged
merged 71 commits into from Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from 67 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
713359a
making adjustments for building dash on a windows machine
BSd3v Feb 7, 2024
011f0cd
syncing lock files
BSd3v Feb 7, 2024
d6ac9e4
removing `rimraf` from .circleci
BSd3v Feb 7, 2024
75647b5
minor adjustments for lint and `mkdir` -> `mkdirp`
BSd3v Feb 7, 2024
7cb5fda
passing black and lint
BSd3v Feb 7, 2024
2f3b91e
adding script for `first-build` to make it easier to start from scratch
BSd3v Feb 7, 2024
ea38361
fixing issue for flake8
BSd3v Feb 7, 2024
2ec3f5c
Revert "passing black and lint"
BSd3v Feb 7, 2024
bf17f12
adjusting test for building on a windows machine
BSd3v Feb 7, 2024
6a4ab95
adjusting test for windows
BSd3v Feb 8, 2024
3a982e5
alerting pip install for test
BSd3v Feb 8, 2024
e59c49d
another attempt
BSd3v Feb 8, 2024
a92bed1
testing regular build process
BSd3v Feb 9, 2024
f0673df
adjusting windows test
BSd3v Feb 9, 2024
785a01b
windows adjustment
BSd3v Feb 9, 2024
c26ebe4
adjusting pip upgrade
BSd3v Feb 9, 2024
e0c6e96
more adjustments
BSd3v Feb 9, 2024
21440c7
adding install for npm
BSd3v Feb 9, 2024
56683d9
adjusting indentation
BSd3v Feb 9, 2024
dd6fb52
Merge branch 'dev' into windows-build-changes
BSd3v Feb 9, 2024
8b2244f
indentation adjustments
BSd3v Feb 9, 2024
3bc4b24
indentation adjustments
BSd3v Feb 9, 2024
ddec347
adjusting command
BSd3v Feb 9, 2024
80af204
adjustments for indent
BSd3v Feb 9, 2024
dd0e477
altering install
BSd3v Feb 9, 2024
8362e7e
adjustments for path commands
BSd3v Feb 9, 2024
0f6ccfa
adding extra python download
BSd3v Feb 9, 2024
9d1d6ec
installing additional req
BSd3v Feb 9, 2024
8e237a4
adjusting first-build to install node_modules
BSd3v Feb 10, 2024
497422c
adjusting build process for path and encoding error
BSd3v Feb 10, 2024
60d34d9
adjustment for path
BSd3v Feb 10, 2024
2d0fe17
adjusting for testing `npm run first-build`
BSd3v Feb 12, 2024
038b496
adjusting `first-build` to use `cd ../../` instead of `cd -`
BSd3v Feb 12, 2024
e8f8be5
breaking build into separate pieces
BSd3v Feb 12, 2024
a944f88
adding python3.12 again, adjusting build to be sequential for compari…
BSd3v Feb 12, 2024
e385e59
adjusting tyop
BSd3v Feb 12, 2024
06aadd2
testing other version of windows machine
BSd3v Feb 12, 2024
926a7a8
testing edge and parallelism
BSd3v Feb 12, 2024
b30437a
adjusting python and pip to run in background since npm prereqs takes…
BSd3v Feb 12, 2024
17bbecd
attempt to use `requires` in a step
BSd3v Feb 12, 2024
173a315
splitting up the pip and python install to run the pip in background
BSd3v Feb 12, 2024
bdd1ed7
removing excess commands
BSd3v Feb 12, 2024
68e1e60
adding `ci` back as a dependency
BSd3v Feb 12, 2024
084d7fa
fixing tyop
BSd3v Feb 12, 2024
779d7d9
wrong way
BSd3v Feb 12, 2024
d22469e
removing `testing` for install
BSd3v Feb 12, 2024
9585334
removing pip upgrade
BSd3v Feb 12, 2024
e4de335
adjusting to windows-server-2019 for circleci
BSd3v Feb 12, 2024
af2a663
adjusting nvm command
BSd3v Feb 12, 2024
98b3fd0
adjusting build windows machine to use large vs medium, removed pytho…
BSd3v Feb 13, 2024
b3db4d8
attempt to disable realtime monitoring
BSd3v Feb 13, 2024
4408c8d
another attempt
BSd3v Feb 13, 2024
49ed875
attempting with privilege
BSd3v Feb 13, 2024
fd71199
attempting with cmd.exe
BSd3v Feb 13, 2024
02516ab
attempt to run as admin
BSd3v Feb 13, 2024
6df738a
adjusting to be string
BSd3v Feb 13, 2024
4404c93
adjusting to powershell
BSd3v Feb 13, 2024
563bab8
attempting to run as powershell admin
BSd3v Feb 13, 2024
d5cc713
removing quotes
BSd3v Feb 13, 2024
46cd80f
attempt to run the command in cmd
BSd3v Feb 13, 2024
856aa36
test
BSd3v Feb 13, 2024
39c479b
adjusting windows test to build jupyter, renderer and dash-html-compo…
BSd3v Feb 13, 2024
588a9b1
Merge branch 'dev' into windows-build-changes
alexcjohnson Feb 13, 2024
7db251f
Update package.json
BSd3v Feb 13, 2024
0919946
Update README.md
BSd3v Feb 13, 2024
2ba55d5
Update package.json
BSd3v Feb 13, 2024
349c4b9
Update package.json
BSd3v Feb 13, 2024
e2226e7
adjusting tests for `\\@plotly` -> `@plotly`
BSd3v Feb 14, 2024
e7cd95a
Merge branch 'windows-build-changes' of github.com:BSd3v/dash into wi…
BSd3v Feb 14, 2024
b220a7b
push to update tests
BSd3v Feb 14, 2024
5184121
updating browser tools
BSd3v Feb 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 17 additions & 7 deletions .circleci/config.yml
Expand Up @@ -150,16 +150,26 @@ jobs:
PERCY_ENABLE: 0
steps:
- checkout

- run:
name: "Install Python"
command: choco install -y python --version=3.12.1

name: pip
command: |
python -m venv venv && . venv/Scripts/activate
pip install --no-cache-dir --upgrade -e .[ci,dev] --progress-bar off
- run:
command: |
nvm install 18 && nvm use 18
- run:
name: ️️🏗️ build core
name: npm prereqs
command: |
py -3.12 -m pip install --no-cache-dir --upgrade -e .[dev,testing] --progress-bar off
cd dash/dash-renderer && C:/Python312/Scripts/renderer.exe build && cd ../../
npm ci
cd dash/dash-renderer && npm i && cd ../../
cd components/dash-html-components && npm i && npm run extract && cd ../../
- run:
name: ️️🏗️ build dash
command: |
. venv/Scripts/activate
npm run private::build.jupyterlab && npm run private::build.renderer && python dash/development/update_components.py 'dash-html-components'
no_output_timeout: 30m

test-312: &test
working_directory: ~/dash
Expand Down
5 changes: 3 additions & 2 deletions @plotly/dash-jupyterlab/package.json
Expand Up @@ -28,7 +28,7 @@
"build:pack": "jlpm run prepare && jlpm pack --filename ../../dash/labextension/dist/dash-jupyterlab.tgz && jlpm run build:copy",
"build:copy": "cp package.json ../../dash/labextension/dist/package.json",
"clean": "rimraf lib",
"prepare": "mkdir -p ../../dash/labextension/dist && jlpm run clean && jlpm run build",
"prepare": "mkdirp ../../dash/labextension/dist && jlpm run clean && jlpm run build",
"prettier": "prettier --write '{!(package),src/**,!(lib)/**}{.js,.jsx,.ts,.tsx,.css,.json,.md}'",
"watch": "tsc -w"
},
Expand All @@ -40,7 +40,8 @@
"devDependencies": {
"prettier": "2.0.5",
"rimraf": "3.0.2",
"typescript": "3.9.3"
"typescript": "3.9.3",
"mkdirp": "^0.5.1"
},
"jupyterlab": {
"extension": true
Expand Down