New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone dash renderer (for custom hooks) - March 1 #367

Merged

valentijnnieman merged 37 commits into master from standalone_dash-renderer

Feb 28, 2019

Contributor

valentijnnieman commented Sep 5, 2018 •

edited

Loading

This enables the dash-renderer to be called as a standalone class, so that we can pass config objects to it.

Depends on this PR that enables dash-renderer to be a standalone class to be merged (also see this PR for an example of how to use a custom DashRenderer instance).

valentijnnieman added 2 commits

September 4, 2018 16:52


          Use DashRenderer as a standalone library

ef0fbeb


          Cleanup code

938e466

valentijnnieman mentioned this pull request

Custom hooks - March 1 plotly/dash-renderer#75

Merged

valentijnnieman changed the title ~~[WIP] Standalone dash renderer (for custom hooks)~~ Standalone dash renderer (for custom hooks)

valentijnnieman requested a review from chriddyp

September 5, 2018 15:40

valentijnnieman added 2 commits

September 5, 2018 11:49


          Update tests with renderer tag

d916765


          Fix linting error

456a090

valentijnnieman changed the title ~~Standalone dash renderer (for custom hooks)~~ [WIP] Standalone dash renderer (for custom hooks)

valentijnnieman added 7 commits

September 5, 2018 11:58


          Refactor generate_renderer function

1e957c7


          Refactor _generate_renderer

e776e8e


          Fixed pylint line too long error

3edaa12


          Fixed pylint trailing whitespace error

41fdc76


          Added test for custom renderer in index string

6c3469f


          Use updated dash-renderer tarball for now

b46f0df


          Also use dash-renderer tarball in dev-requirements.txt

bd8c9fb

valentijnnieman changed the title ~~[WIP] Standalone dash renderer (for custom hooks)~~ Standalone dash renderer (for custom hooks)

valentijnnieman added 2 commits

September 5, 2018 16:21


          Update dev-requirements-py37

d4b0418


          dash-renderer tarball in dev-requirements-py37

d0120db

valentijnnieman mentioned this pull request

Circleci breaking for Python 2.7 #368

Closed


          Merged with master & resolved merge conflicts

421cd2d

chriddyp reviewed

View reviewed changes

dash/dash.py Show resolved Hide resolved

chriddyp reviewed

View reviewed changes

tests/test_integration.py Outdated Show resolved Hide resolved

chriddyp reviewed

View reviewed changes

tests/test_integration.py Show resolved Hide resolved

chriddyp reviewed

View reviewed changes

tests/test_integration.py Outdated Show resolved Hide resolved

chriddyp reviewed

View reviewed changes

dash/dash.py Outdated Show resolved Hide resolved

Member

chriddyp commented Sep 12, 2018

This side of the code is looking good to me! @T4rk1n could you take a look as well?

chriddyp requested a review from T4rk1n

September 12, 2018 21:17

chriddyp approved these changes

View reviewed changes

chriddyp added the dash-meta-sponsored label

T4rk1n reviewed

View reviewed changes

Contributor

T4rk1n left a comment

Looks good, only a couple minor changes.

Also before release, would we need to lock the version of dash-renderer in setup.py since the starting of the renderer has changed and now needs the new Renderer syntax ?

dash/dash.py Show resolved Hide resolved

dash/dash.py Outdated Show resolved Hide resolved

Contributor

Akronix commented Oct 10, 2018

Hi. Can I ask how is the status of this? Is it in your roadmap or is there any tentative date for its release?

chriddyp changed the title ~~Standalone dash renderer (for custom hooks)~~ Standalone dash renderer (for custom hooks) - March 1

valentijnnieman added 9 commits

February 15, 2019 14:34


          Merge branch 'master' of https://github.com/plotly/dash into standalo…

2486dcb

…ne_dash-renderer


          Try dash-renderer egg instead of tarball 🥚

01b3216


          Add egg to dev-req files too 🥚

f3a85ca


          Use egg of custom_hooks branch of dash-renderer in circleci config too 🥚

ea2b623


          Use ActionChain instead of .clear() to fix tests

1358dbe


          Add correct interpolated index test & fix wildcard test

f9002e1


          Remove print from test 🙈


          Fix formatting

bf651ff


          Remove unused code

ba95dc6

alexcjohnson reviewed

View reviewed changes

dash/dash.py Outdated Show resolved Hide resolved

alexcjohnson reviewed

View reviewed changes

dash/dash.py Outdated Show resolved Hide resolved

alexcjohnson reviewed

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

alexcjohnson reviewed

View reviewed changes

tests/test_integration.py Outdated Show resolved Hide resolved

valentijnnieman added 7 commits

February 27, 2019 10:25


          Remove unused requirements files

b94ca9a


          Changed renderer param example string

11d98a1


          Add check for new DashRenderer

caf21a2


          const -> var

d15f0ba


          Missing > in script tag

4797b2a


          Remove unused wait_for methods

7fc8a80


          Revert renderer scripts check

5fbadf1

alexcjohnson approved these changes

View reviewed changes

Collaborator

alexcjohnson left a comment

OK, I think we're home free! Thanks for the changes this morning @valentijnnieman!
💃
The conflicts in requirements can be resolved in favor of the current master:
-e git://github.com/plotly/dash-renderer.git@master#egg=dash_renderer
if the renderer PR is merged first so that's on master.


          Merge branch 'master' of https://github.com/plotly/dash into standalo…

1c59379

…ne_dash-renderer

valentijnnieman merged commit f22973d into master

alexcjohnson deleted the standalone_dash-renderer branch

March 1, 2019 03:13

anders-kiaer mentioned this pull request

DashRenderer initialization and CSP #630

Closed

alexcjohnson mentioned this pull request

dash.exceptions.InvalidIndexException after upgrading Dash #641

Closed

HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request


          Update all dependencies (plotly#367)

5af0b1c

HammadTheOne pushed a commit that referenced this pull request


          Update all dependencies (#367)

0ceb0c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment