Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http-equiv typo. #418

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Fix http-equiv typo. #418

merged 4 commits into from
Oct 17, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Oct 4, 2018

Fix missing http in default http-equiv meta tag include.

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Oct 4, 2018

@rmarren1 I don't understand the failure of py 3.6 and 3.7, there was no modifications to that part of code.

@rmarren1
Copy link
Contributor

rmarren1 commented Oct 5, 2018

Strange, the test passes locally for me. I started getting the same error a few days ago and thought it was something in the code.

I'll look into it, looks like a python path issue with Python3 was introduced somehow, perhaps in the CircleCI docker images? Perhaps we can just run the same test in a different way to that it works again.

@rmarren1
Copy link
Contributor

rmarren1 commented Oct 5, 2018

#419

@T4rk1n T4rk1n force-pushed the fix-http-equiv branch 2 times, most recently from 8db6a2f to 98ce612 Compare October 17, 2018 17:36
@T4rk1n
Copy link
Contributor Author

T4rk1n commented Oct 17, 2018

@rmarren1 I skipped the test, please review.

@T4rk1n T4rk1n merged commit 02eb3f2 into master Oct 17, 2018
@T4rk1n T4rk1n deleted the fix-http-equiv branch October 17, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants