Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path issue in Python3 Circleci #419

Closed
rmarren1 opened this issue Oct 5, 2018 · 2 comments
Closed

Path issue in Python3 Circleci #419

rmarren1 opened this issue Oct 5, 2018 · 2 comments
Assignees

Comments

@rmarren1
Copy link
Contributor

rmarren1 commented Oct 5, 2018

There is an error when attempting to create then dynamically import a module in the test cases: https://circleci.com/gh/plotly/dash/1251?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.

@rmarren1 rmarren1 self-assigned this Oct 5, 2018
@T4rk1n
Copy link
Contributor

T4rk1n commented Oct 12, 2018

All new branch fail on 3.6 and 3.7 can we skip the test while you work on a fix ?

@rmarren1
Copy link
Contributor Author

Yeah skip it! Sorry, overlooked this in my inbox.

There is a similar test in test_base_component.py which makes sure the the string created and then imported by the dynamic loader is the same as the string written to the python class files, so skipping this shouldn't leave a huge gap.

My only concern is that sometime in the future the _imports_.py file might get messed up and you would not be able to import the class files even though they are structured perfectly. I will add a test for this rather than the module import that is breaking.

This was referenced Oct 18, 2018
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this issue May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants