typo in exception names #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcjohnson @T4rk1n Any way users would be doing selective error handling against this error type? If so this would be a breaking change to the 0.x API and warrant either a minor bump + changelog entry or be pushed to Dash 1.0 |
|
@Marc-Andre-Rivet I doubt it, I don't see any way these can occur that's not simply a mistake on the user's part. But I'm also happy to simply remake this PR against release-v1 and not worry about it. |
|
@alexcjohnson I'll take you at your word. Just add an unreleased entry to the changelog and I'm good to go. |
Marc-Andre-Rivet
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just fixing a typo that's been annoying me
cc @T4rk1n