Make component generator accept whitespace in paths #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Dash boilerplate project is set up at a path involving whitespaces, the invocation of the `extract-meta.js` script through Node will trip up. Quoting the script path should help prevent the latter from being interpreted as a series of arguments (i.e. whitespace being the delimiter). Furthermore, a quirk with non-POSIX mode with `shlex` means the split call will still try to delimit the script path, even though it is quoted. So irrespective of OS, this should be turned off. plotly/dash-component-boilerplate#71
miqh
requested review from
alexcjohnson,
byronz and
Marc-Andre-Rivet
as code owners
|
This looks good to me, but as I don't have access to a Windows machine and this was recently edited in #915 perhaps @stevej2608 would like to chime in on whether this change is a good idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've made some tweaks to the component generator in an attempt to make it more lenient with the paths that Dash boilerplate projects can be set up at. Specifically, paths with whitespace should now be acceptable.
Some remarks concerning the changes:
extract-meta.jsscript helps avoid it being interpreted as multiple arguments (i.e. delimited by whitespace) when passed to Nodeshlex.split()appears to undesirably interfere with the script path, producing something incorrect on my Windows box, which I thought was odd.shell=Truebecause according to thesubprocess.Popendocumentation, "The only time you need to specify shell=True on Windows is when the command you wish to execute is built into the shell (e.g. dir or copy)."I also tested these changes on an Ubuntu box to see whether paths with whitespace could work, and they did.
Relevant issue reported previously: plotly/dash-component-boilerplate#71