Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require patched version of reqres to handle cookies containing multiple "=" #122

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Aug 27, 2019

As noted in thomasp85/reqres/pull/9, parse_cookies may throw an error if cookies containing multiple instances of = are encountered (such as those related to Google Analytics).

This PR modifies the DESCRIPTION file to pull down a patched version of requests.R which splits the cookie strings in two, at the first = only.

@rpkyle rpkyle added the bug label Aug 27, 2019
@rpkyle rpkyle self-assigned this Aug 27, 2019
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@rpkyle rpkyle merged commit d080de4 into master Aug 27, 2019
@rpkyle rpkyle deleted the 13385-fix-cookie-handling branch August 27, 2019 01:33
@rpkyle rpkyle mentioned this pull request Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants