Dash for R v0.2.0 #162
Merged
Dash for R v0.2.0 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename pruned_errors to prune_errors * rename pruned to prune * provide support for no_update in Dash for R (#111)
* rename pruned_errors to prune_errors * rename pruned to prune * 🔨 handle stop errors * 🚨 add test for stop errors
* Add line number context to stack traces when srcrefs are available (#133) * ✨ Support line #s when in debug mode * ✨ Add use_viewer option for RStudio * 🚨 Add soft and hard hot reloading tests
add always
* ✨ initial support for meta tags * support arbitrary tags * 🚨 add tests * 🔬 add asserts * add reference to meta tag PR * ⏩ indent meta tags
* add eager_loading parameter * 📛 add buildFingerprint * 📛 add checkFingerprint * use getDependencyPath, + 🐾/Etag support * updates to support async * ✨ properly support gz compression * 🐛 post-async fixes for CSS handling
…races (#137) * 🚚 upgrade dash-renderer to v1.2.2, 🔨 fix stack traces * 🚚 add polyfill.js
HammadTheOne
reviewed
Jan 3, 2020
| # serving order of CSS and JS tags: package -> external -> assets | ||
| css_tags <- paste(c(css_deps, | ||
| css_external, | ||
| css_assets), | ||
| collapse = "\n") | ||
|
|
||
| collapse = "\n ") |
There was a problem hiding this comment.
Is this whitespace necessary here, and in the following instances of css_tags?
There was a problem hiding this comment.
Yeah, this is an attempt to properly indent the tags.
HammadTheOne
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges in changes to Dash for the v0.2.0 release. The major improvements include:
dashNoUpdate()dash-rendererupdated to v1.2.2The full list of changes follows below.
Added
brotli,gzip, ordeflate#157<meta>tags to index #142use_viewer = TRUEdashNoUpdate()#111app$get_asset_urlwhen app is loaded viasource()orAPP_ROOT_PATHenvironment variable is defined #160url_base_pathnameadded; mimics functionality in Dash for Python, sets defaults forroutes_pathname_prefixandrequests_pathname_prefixwhen not otherwise provided #161Changed
dash-rendererupdated to v1.2.2 #137reqres, patch applied upstream thomasp85/reqres#9pruned_errorsparameter has been renamed todev_tools_prune_errors#113Fixed
debug = TRUEanduse_viewer = TRUE#137reqrespackage to handle cookies containing multiple "=" #122get_asset_urlchecksgetAppPath()as well asDASH_APP_ROOT_PATHenvironment variable when invoked #161