Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for config-aware relative paths #172

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Add support for config-aware relative paths #172

merged 4 commits into from
Feb 12, 2020

Conversation

HammadTheOne
Copy link
Contributor

@HammadTheOne HammadTheOne commented Jan 23, 2020

This PR addresses the addition of config-aware relative URL routes for Dash for R by adding in two new methods: get_relative_path and strip_relative_path. The implementation of these methods is analogous to the Python version, and it addresses parity between the two versions.

Closes #170.

@rpkyle rpkyle changed the title 170 - Config-aware relative paths Add support for config-aware relative paths Feb 11, 2020
Copy link
Contributor

@rpkyle rpkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 I've made a minor change to the documentation to correct a typo, but otherwise this looks ready to go!

@rpkyle rpkyle merged commit 2f1be58 into dev Feb 12, 2020
@rpkyle rpkyle deleted the 170-relative-paths branch February 12, 2020 00:26
@rpkyle rpkyle mentioned this pull request Feb 12, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)

* Inspect environment variables for host & port (#167)

* Support for index page templating (#168)

* Add support for config-aware relative paths (#172)

* Add unit tests for index customization (#176)

* Send status code of 1 when unit tests fail (#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants