Remove DASH_HOST and DASH_PORT, use std vars #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it okay to have this BC break? |
josegonzalez
approved these changes
Jan 13, 2020
|
Yes, now's the time for breaking compatibility in the name of standardization. |
Merged
rpkyle
added a commit
that referenced
this pull request
Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165) * Inspect environment variables for host & port (#167) * Support for index page templating (#168) * Add support for config-aware relative paths (#172) * Add unit tests for index customization (#176) * Send status code of 1 when unit tests fail (#177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to replace
DASH_HOSTandDASH_PORTwithHOSTandPORT, since the former were never actively used in practice, and for parity with Dash for Python.