This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Use electron-builder and webpack@3 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move Windows and Mac icons from app to app/icons. * Generate icons for Linux.
* Fixed the build configuration so that electron-builder can generate installers for Windows (nsis), Mac (dmg) and Linux (tar.gz, deb and AppImage). * Moved electron and electron-sudo to devDependencies. * Removed electron-rebuild. * Upgraded electron-builder to v19.46.4.
* Added fix for module ibm_db in mac to `scrips/install-modules.js`. See issue: ibmdb/node-ibm_db#329
* Renamed `scripts/install-modules.js` to `scripts/rebuild-modules.js`.
* Moved all the dependencies not listed as external in the webpack configs from dependencies to devDependencies.
- Restored immutable to silence warning that react-immutable-proptypes has unmet peer dependency. - Restored babel-runtime to silence warning that react-dock has un unmet peer dependency. - Fixed versions of csv-parse, fs-extra and mkdirp.
* So that electron-rebuild packs a rebuilt ibm_db module that includes the fix for issue: ibmdb/node-ibm_db#329
* Remove `yarn run rebuild:modules:electron` (as `yarn run pack` also runs it). * Only zip the .exe installer.
* Pin only major versions of node and use default version of yarn. * Replace `yarn run package` with `yarn run pack`. * Remove `yarn run rebuild:modules:electron` (as `yarn run pack` also runs it).
* Kept `restify`, `ramba`, `electron-mocha` and `chai` pinned to the current major version, because an upgrade would require code changes.
* Removed unnecessary zip step. * Pin node to major version only.
n-riesco
force-pushed
the
refactor-build-and-pack
branch
from
42951d5
to
a10ac3b
Compare
chriddyp
reviewed
Nov 24, 2017
package.json
Outdated
| @@ -156,10 +157,11 @@ | |||
| "fetch-cookie": "^0.6.0", | |||
| "fixed-data-table": "^0.6.4", | |||
| "form-data": "^2.3.1", | |||
| "fs-extra": "https://registry.npmjs.org/fs-extra/-/fs-extra-0.26.7.tgz", | |||
| "fs-extra": "^4.0.2", | |||
| "immutable": "^3.8.2", | |||
There was a problem hiding this comment.
I'm pretty sure that we've gotten rid of immutable everywhere, and that these prop type descriptions https://github.com/plotly/falcon-sql-client/blob/92755984257409dcdcfb29231e272d8e4d2d174d/app/components/Settings/Logger/Logger.react.js#L33 are actually incorrect. We can change this in a future PR though
There was a problem hiding this comment.
I kept it to silence the warning that immutable is a peer depedency of react-immutable-proptypes.
There was a problem hiding this comment.
right - i mean, we can probably remove all of the react-immutable-proptypes throughout our code as well
|
this looks great! 💃 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chriddyp Could you review this PR?
I haven't gone as far as I originally planned with this work, but I'm going to open a PR in the main repo, so that people can test the installers generated with
electron-builder.A brief overview of what this PR does:
ibm_dbfrom my repo with @tarzzz 's fix (this is necessary forelectron-builderto work)Now the procedure to generate installers is:
(Beware that
yarn packandyarn run packdo different things)The procedure to build the app locally and test is still the same: