Add more input events #1392
Merged
Add more input events #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ular brush or convex hull of lasso brush
…ample app for proof-of-concept
…pported event is provided
cpsievert
force-pushed
the
input-events
branch
from
a2bc488
to
f293486
Compare
Also introduces new R functions to explictly register/un-register events
…s requesting is not yet registered
cpsievert
commented
Jan 31, 2019
…eactive system is flushed
jcheng5
reviewed
Feb 5, 2019
jcheng5
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changes to NEWS.md for the relevant improvements.
Testing Notes
Install
devtools::install_github("ropensci/plotly#1392"). Run any apps under https://github.com/ropensci/plotly/tree/input-events/inst/examples/shiny that start with 'event_data' and verify they do a sensible thing (happy to walk you through that)