make trace uid accept numbers

plotly · Jan 10, 2019 · 4ef048f · 4ef048f
1 parent c087b0a
commit 4ef048f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -563,7 +563,10 @@ function getTraceUids(oldFullData, newData) {
     }
 
     for(i = 0; i < len; i++) {
-        if(tryUid(newData[i].uid, i)) continue;
+        var newUid = newData[i].uid;
+        if(typeof newUid === 'number') newUid = String(newUid);
+
+        if(tryUid(newUid, i)) continue;
         if(i < oldLen && tryUid(oldFullInput[i].uid, i)) continue;
         setUid(Lib.randstr(seenUids), i);
     }

diff --git a/test/jasmine/tests/plots_test.js b/test/jasmine/tests/plots_test.js
@@ -153,6 +153,26 @@ describe('Test Plots', function() {
 
             testSanitizeMarginsHasBeenCalledOnlyOnce(gd);
         });
+
+        it('should accept trace uids as non-empty strings or numbers', function() {
+            var gd = {
+                data: [{}, {uid: false}, {uid: 'my-id'}, {uid: ''}, {uid: 0}, {uid: 2}]
+            };
+            supplyAllDefaults(gd);
+
+            var traceUids = gd._fullLayout._traceUids;
+            expect(traceUids.length).toBe(6, '# of trace uids');
+            expect(traceUids[2]).toBe('my-id');
+            expect(traceUids[4]).toBe('0');
+            expect(traceUids[5]).toBe('2');
+
+            var indicesOfRandomUid = [0, 1, 3];
+            indicesOfRandomUid.forEach(function(ind) {
+                var msg = 'fullData[' + ind + '].uid';
+                expect(typeof traceUids[ind]).toBe('string', msg + 'is a string');
+                expect(traceUids[ind].length).toBe(6, msg + 'is of length 6');
+            });
+        });
     });
 
     describe('Plots.supplyLayoutGlobalDefaults should', function() {