Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with autobins #3336

Closed
nicolaskruchten opened this issue Dec 14, 2018 · 6 comments
Closed

Regression with autobins #3336

nicolaskruchten opened this issue Dec 14, 2018 · 6 comments
Labels
bug something broken regression this used to work

Comments

@nicolaskruchten
Copy link
Contributor

Found this while upgrading RCE for 1.43.0 but I think it was introduced earlier: https://codepen.io/nicolaskruchten/pen/LMNGNP?editors=0010

@archmoj
Copy link
Contributor

archmoj commented Dec 14, 2018

@nicolaskruchten Your demo is working well with 1.41.2; but not using 1.42.0.

@archmoj archmoj added the regression this used to work label Dec 14, 2018
@etpinard
Copy link
Contributor

It's probably from #3044 (to was released in 1.42.0).

Can I ask, what's the expected behavior?

@etpinard
Copy link
Contributor

For sure, we want newPlot and react to result in the same graph, but how should that graph look like?

@archmoj
Copy link
Contributor

archmoj commented Dec 14, 2018

@etpinard Could you please try this demo

@nicolaskruchten
Copy link
Contributor Author

nicolaskruchten commented Dec 14, 2018

what's the expected behavior?

same as an empty scatter or other trace... it should get added to fullData etc... right now the editor gets wedged.

@nicolaskruchten
Copy link
Contributor Author

It might be worth adding a test that guarantees that for all trace types there's clearly defined behaviour for just {type: 'type'} as the entry in data... Basically we don't need to show anything, but we also can't raise an error and we do need a full entry in fullData that allows the editor to populate its widgets etc.

etpinard added a commit that referenced this issue Dec 17, 2018
…ties

fixes #3336 - don't try to makeCalcdata on visible:false traces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

No branches or pull requests

3 participants