Fix range slider svg / eps / pdf exports #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it was causing pdf/eps export to fail because the <rect> node didn't have x/y/width/height attributes - remove it as the range slider bg is all we need here
- so that rgba color is set as:
`fill: ${rgb}` + `fill-opacity: ${alpha}`
for compatibility with eps/pdf exports
- these were also no exporting to pdf/eps well as they used a `fill: 'transparent` style
|
LGTM 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range slider svg / eps / pdf exports are currently failing on plot.ly.
This PR ensures that
<rect>elements have set x/y/width/height attributes (no setting those makes the SVG invalid)fill+fill-opacityattributes (Batik doesn't likefill: ${rgba})fill: 'transparentelements are not drawn on static plots (Batik doesn't likefill: 'transparent')