Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range slider svg / eps / pdf exports #1306

Merged
merged 4 commits into from
Jan 17, 2017
Merged

Fix range slider svg / eps / pdf exports #1306

merged 4 commits into from
Jan 17, 2017

Commits on Jan 17, 2017

  1. rm cartesian bg layer in range slider range plot 

    - it was causing pdf/eps export to fail because the <rect>
  node didn't have x/y/width/height attributes
- remove it as the range slider bg is all we need here
    @etpinard
    etpinard committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    375ff11 View commit details
    Browse the repository at this point in the history

  2. color range slider mask rect with Color.fill 

    - so that rgba color is set as:
  `fill: ${rgb}` + `fill-opacity: ${alpha}`
  for compatibility with eps/pdf exports
    @etpinard
    etpinard committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    862465a View commit details
    Browse the repository at this point in the history

  3. don't draw range slider slide + grab area box in static plots 

    - these were also no exporting to pdf/eps well
  as they used a  `fill: 'transparent` style
    @etpinard
    etpinard committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    841667e View commit details
    Browse the repository at this point in the history

  4. add range_slider_initial_valid to image export test cases

    @etpinard
    etpinard committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    09a807d View commit details
    Browse the repository at this point in the history