-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splom zoom perf #2527
Merged
Merged
Splom zoom perf #2527
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
02ed2eb
move doAutoRangeAndConstraints, drawData and finalDraw to subroutines
etpinard 3ad1eaa
add 'axrange' editType
etpinard bb02281
speed up doModeBar subroutines for cartesian subplots
etpinard d07ae70
improve fullLayout._has()
etpinard 468119e
speed up dragbox
etpinard 0979272
clean splom drag logic
etpinard ebb35ce
lint in plot_api
etpinard f9090b7
(fixup) add draggedPts to scattercarpet categories
etpinard b2ee736
Merge branch 'splom-feature' into splom-zoom-perf
etpinard a0b2574
Merge branch 'splom-feature' into splom-zoom-perf
etpinard d3fe40d
replace selectAll with for(k in _plots) loop
etpinard cc1b3de
fixup and :lock: dragbox with linked y axes
etpinard 980855c
Merge branch 'splom-feature' into splom-zoom-perf
etpinard f7d637d
:books: link TODOs to gh issues
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I'd have thought so... perhaps worth spending a little time looking for something that does fail if this is removed, so it can be 馃敀 down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcjohnson Tests are currently passing even when
subroutines.doAutoRangeAndConstraints
is commented out, because of this block:plotly.js/src/plot_api/plot_api.js
Lines 2088 to 2107 in 2a25820
which makes axis range relayout calls altering constrained axes go though the
calc: true
edit pathway which (of course) callsdoAutoRangeAndConstraints
itself.Interestingly, commenting out that block which sets
flags.calc = true
does not make any test fails whensubroutines.doAutoRangeAndConstraints
is called duringaxrange
edits. Perhaps we don't need?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look to me as though I wrote all that great test coverage for this section... the two key points of it are:
relayout
a constrained axis, particularly to a smaller range, and have the other axes in the group update (expanding or shrinking) to continue to meet the constraints (note that this won't work withreact
, there you'd have to manually update all axes in the constraint group)relayout
(orreact
) two or more axes in a group in such a way as to explicitly violate the constraints, one or more of those axes will expand (never shrink) its range to fit the constraints.So if you want to clean this up we should first add a few tests explicitly for ^^. I see some gui tests and one restyle test that uses constraints, but unfortunately no
relayout
orreact
tests of these edge cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok if I open up an issue about this and defer this to a later PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep for sure - that was the "if you want to clean this up" clause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to -> #2540