Do not clear _glcanvas ref during layout replot edits #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some edits may call makePlotFramework, we can't clear the ref to glcanvas there as we need to properly clear the canvases.
|
Looks OK to me - new test is beautiful, and as it doesn't break any existing tests it can't be too bad! But I'd like @dy to give the 💃 since he added this in the first place. |
|
LGTM! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2791
Some edits may call
makePlotFrameworkin plot_api.js, we can't clear the ref to glcanvas there as we need to properly clear the canvases.cc @alexcjohnson @dy