scatter3d display errorbars when error_z is not specified #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinerg
added
bug
antoinerg
changed the title
etpinard
reviewed
Sep 14, 2018
src/traces/scatter3d/convert.js
Outdated
| color[i] = str2RgbaArray(e.color); | ||
| lineWidth = e.thickness; | ||
| lineWidth = (e.thickness || errorBarsAttributes.thickness.dflt); |
There was a problem hiding this comment.
Hmm. Strange, judging from
fullData[i].thickness should have a set value by the time it gets here.
There was a problem hiding this comment.
Note that having values set in fullData is (very) important for the react-chart-editor (aka RCE). RCE uses fullData to fill in its UI components.
gl3d_errobars_zx.json had to be updated because thickness is defined per axis instead of previously being determined by the thickness of error_z
|
Looks good 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2881 by reverting to default values when error_z is not specified by the user.