882 - Chart Title Alignment #3276
Commits on Nov 21, 2018
-
-
-
Implement basic chart title alignment options [882]
- Not cleaned up. - Padding attributes missing. - `auto` values missing.
-
Add test to ensure current chart title position is still supported [882]
- Current position means the title's baseline sits in the middle of the to margin.
-
Support deprecated axes titles syntax for multiple axes [882]
- For initial render and update through relayout/update.
-
-
-
-
Adapt colorbar to new title attr structure [882]
- colorbar is using the titles component to draw its title and therefore needed to adapt to the attribute structure assumed by the titles component.
-
-
Transition polar plot type to new title attr structure [882]
- Adapt layout attributes. - Extend compatibility code in `cleanLayout`. - Adapt polar drawing code. - Adapt tests being based on old title attr structure.
-
-
Transition ternary plot type to new title attr structure [882]
- Adapt layout attributes. - Extend compatibility code in `cleanLayout`. - Adapt ternary drawing code. - Adapt tests being based on old title attr structure. - Test relayouting title attributes.
-
Transition gl3d plot type to new title attr structure [882]
- Adapt layout attributes. - Extend compatibility code in `cleanLayout`.
-
-
Expect new title syntax in legend, lib and further tests [882]
- Further being splom, validate and template tests.
-
-
-
-
-
-
Restrict title.y (and x) to a number between 0 and 1 [882]
- Special coerce logic for y because it can be 'auto' also.
-
Minor clean up in subroutines.js [882]
- Eliminate an unnecessary else block.
-
Fix cleaning deprecated title structure on relayout/update [882]
- Bug: Using an attribute string representing the deprecated title structure to unset a value wasn't supported.
-
- Bug: if only a `titlefont` but no `title` was set, `cleanTitle` would not create the new title structure.
Commits on Nov 22, 2018
-
Still accept numbers as titles when defined in deprecated notation [882]
- Before introducing the new title attribute structure, a title could have been defined as a number as well - which is a feature of the string attribute coerce function.
-
Improve and simplify title compatibility code for relayout [882]
- Downsize the cleaning of relayout attributes to one method. - Allow titles to be numbers, not just strings. - Call cleaning method just in one place. - Make comments more clear.
Commits on Nov 23, 2018
-
Clear TODOs in gl3d axis_defaults.js and cloneplot.js [882]
- Have been clarified in respective PR.
-
Streamline variable names in subroutines.js [882]
- In fact `fullLayout._size` is usually called `gs` for "graph size" when being extracted to a variable.
-
Deprecate old title structure properly [882]
- Add _deprecated attributes to attribute definitions. - Mention deprecation in new title attributes.
-
Fix plotschema_test.js to embrace deprecated attribute containers [882]
- Reason: deprecating `titlefont` was the first time a container, not only a value object, has been deprecated.
-
Commits on Nov 26, 2018
-
-
Reuse Lib.counterRegex to match deprecated title string attributes [882]
- Add `matchBeginning` parameter to `regex.counter`.
-
Pass back update data unmodified to plotly_relayout event handlers [882]
- ... even if deprecated layout attributes have been cleaned up internally. - Reason: to stay backwards-compatible with existing event handlers that count on the old titles structure for example.
-
Redeclare valType of title.y to be a 'number' [882]
- Swichting the valType to 'number' spares the custom coerce function. - In addition fixes the missing min and max bounds for y.
Commits on Nov 27, 2018
-
-
-
Transition color bar to new title attr structure [882]
- This transitions all traces depending on `colorbar` as well.
Commits on Nov 28, 2018
-
Transition carpet to new title attr structure [882]
- Also remove unnecessary code in carpet implementation.
Commits on Nov 29, 2018
-
Let '' be the default carpet axes title [882]
- Reason: having no default at all for `title.text` would lead to a non-existing `title` container (through a call to `relinkPrivateKeys` deep down the stack) eventually and as consequence would require to safeguard access to `[ab]axis.title.text` by checking `[abaxis.title]` is defined before.
-