finalist: Errorbars inherit color from line or marker color #3408
Conversation
|
Hmm. I don't think we should be considering this a bug fix. This changes a few of our baselines. Personally, I think this PR belongs in the |
archmoj
added
status: has TODOs
status: on hold
and removed
status: reviewable
status: has TODOs
labels
src/traces/bar/defaults.js
Outdated
| errorBarsSupplyDefaults(traceIn, traceOut, Color.defaultLine, {axis: 'y'}); | ||
| errorBarsSupplyDefaults(traceIn, traceOut, Color.defaultLine, {axis: 'x', inherit: 'y'}); | ||
| errorBarsSupplyDefaults(traceIn, traceOut, lineColor || markerColor || Color.defaultLine, {axis: 'y'}); | ||
| errorBarsSupplyDefaults(traceIn, traceOut, lineColor || markerColor || Color.defaultLine, {axis: 'x', inherit: 'y'}); |
There was a problem hiding this comment.
I don’t think markerColor belongs here. That would be invisible against the bars themselves, right? I like lineColor though.
There was a problem hiding this comment.
@alexcjohnson there is also this PR for possibly only fixing this on scatter traces...
|
True, it contains a bit of a change, but mostly I’d call this fixing a bug. To me it’s not such a change that it should be considered breaking but I can understand not calling it just a patch. |
Sounds good, let's panned this one for |
|
💃 nicely done @archmoj ! |
fix #3392 for 5 traces.
Note 1: For
barandhistogramcasesmarker.line.coloris applied as the default color. If undefined then `marker.color' is used if defined.Note 2: For
scatter,scatter3dandscatterglcasesline.coloris applied as the default color. If undefined thenmarker.color' is used if defined. Also note thatmarker.line.coloris not used in this regard; and the trace line color and errorbar lines would usecolorway` in that scenario.@plotly/plotly_js