-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finalist: Errorbars inherit color from line or marker color #3408
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [0, 100, 500, 600, 0], | ||
| "type": "bar", | ||
| "barmode": "group", | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [100, 200, 600, 700, 100], | ||
| "type": "bar", | ||
| "barmode": "group", | ||
| "marker": { | ||
| "line": { | ||
| "width": 2, | ||
| "color": "gray" | ||
| } | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [200, 300, 700, 800, 200], | ||
| "type": "bar", | ||
| "barmode": "group", | ||
| "marker": { | ||
| "color": "red" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [300, 400, 800, 900, 300], | ||
| "type": "bar", | ||
| "barmode": "group", | ||
| "marker": { | ||
| "line": { | ||
| "color": "green" | ||
| } | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [400, 500, 900, 1000, 400], | ||
| "type": "bar", | ||
| "barmode": "group", | ||
| "marker": { | ||
| "line": { | ||
| "color": "blue" | ||
| }, | ||
| "color": "black" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| } | ||
| ], | ||
| "layout": { | ||
| "width": 600, | ||
| "heigh": 600, | ||
| "title": { | ||
| "text": "Bar chart error bars inherit color from marker.line or marker" | ||
| } | ||
| } | ||
| } |
74 changes: 74 additions & 0 deletions
74
test/image/mocks/gl2d_scattergl_errorbars_inherit_color.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [0, 100, 500, 600, 0], | ||
| "type": "scattergl", | ||
| "mode": "markers+lines", | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [100, 200, 600, 700, 100], | ||
| "type": "scattergl", | ||
| "mode": "markers+lines", | ||
| "marker": { | ||
| "line": { | ||
| "width": 2, | ||
| "color": "gray" | ||
| } | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [200, 300, 700, 800, 200], | ||
| "type": "scattergl", | ||
| "mode": "markers+lines", | ||
| "marker": { | ||
| "color": "red" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [300, 400, 800, 900, 300], | ||
| "type": "scattergl", | ||
| "mode": "markers+lines", | ||
| "line": { | ||
| "color": "green" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [400, 500, 900, 1000, 400], | ||
| "type": "scattergl", | ||
| "mode": "markers+lines", | ||
| "line": { | ||
| "color": "blue" | ||
| }, | ||
| "marker": { | ||
| "color": "black" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| } | ||
| ], | ||
| "layout": { | ||
| "width": 600, | ||
| "heigh": 600, | ||
| "title": { | ||
| "text": "Scatter-gl error bars inherit color from line or marker" | ||
| } | ||
| } | ||
| } |
79 changes: 79 additions & 0 deletions
79
test/image/mocks/gl3d_scatter3d_errorbars_inherit_color.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [-5, -10, -30, -35, -5], | ||
| "z": [0, 0, 0, 0, 0], | ||
| "type": "scatter3d", | ||
| "mode": "markers+lines", | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [-5, -10, -30, -35, -5], | ||
| "z": [1, 1, 1, 1, 1], | ||
| "type": "scatter3d", | ||
| "mode": "markers+lines", | ||
| "marker": { | ||
| "line": { | ||
| "width": 2, | ||
| "color": "gray" | ||
| } | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [-5, -10, -30, -35, -5], | ||
| "z": [2, 2, 2, 2, 2], | ||
| "type": "scatter3d", | ||
| "mode": "markers+lines", | ||
| "marker": { | ||
| "color": "red" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [-5, -10, -30, -35, -5], | ||
| "z": [3, 3, 3, 3, 3], | ||
| "type": "scatter3d", | ||
| "mode": "markers+lines", | ||
| "line": { | ||
| "color": "green" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [0, 1, 2, 3, 4], | ||
| "y": [-5, -10, -30, -35, -5], | ||
| "z": [4, 4, 4, 4, 4], | ||
| "type": "scatter3d", | ||
| "mode": "markers+lines", | ||
| "line": { | ||
| "color": "blue" | ||
| }, | ||
| "marker": { | ||
| "color": "black" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| } | ||
| ], | ||
| "layout": { | ||
| "width": 600, | ||
| "heigh": 600, | ||
| "title": { | ||
| "text": "Scatter3d error bars inherit color from line or marker" | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "x": [0, 1, 5, 6, 0], | ||
| "type": "histogram", | ||
| "barmode": "stack", | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [1, 2, 6, 7, 1], | ||
| "type": "histogram", | ||
| "barmode": "stack", | ||
| "marker": { | ||
| "line": { | ||
| "width": 2, | ||
| "color": "gray" | ||
| } | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [2, 3, 7, 8, 2], | ||
| "type": "histogram", | ||
| "barmode": "stack", | ||
| "marker": { | ||
| "color": "red" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [3, 4, 8, 9, 3], | ||
| "type": "histogram", | ||
| "barmode": "stack", | ||
| "marker": { | ||
| "line": { | ||
| "color": "green" | ||
| } | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| }, | ||
| { | ||
| "x": [4, 5, 9, 10, 4], | ||
| "type": "histogram", | ||
| "barmode": "stack", | ||
| "marker": { | ||
| "line": { | ||
| "color": "blue" | ||
| }, | ||
| "color": "black" | ||
| }, | ||
| "error_y": { | ||
| "type": "sqrt" | ||
| } | ||
| } | ||
| ], | ||
| "layout": { | ||
| "width": 600, | ||
| "heigh": 600, | ||
| "title": { | ||
| "text": "Histogram error bars inherit color from marker.line or marker" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think
markerColorbelongs here. That would be invisible against the bars themselves, right? I likelineColorthough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes totally agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcjohnson there is also this PR for possibly only fixing this on scatter traces...