replace prepend() calls since they aren't supported in IE11 #3491
Conversation
|
@etpinard The failing example provided by @wbrgss was tested to work under IE11 on Windows 10 by using the build from the current branch: https://plnkr.co/edit/SDQf3lmpKgltoTEoNYW8?p=preview |
src/components/modebar/modebar.js
Outdated
| @@ -88,7 +88,9 @@ proto.update = function(graphInfo, buttons) { | |||
| } | |||
|
|
|||
| if(fullLayout.modebar.orientation === 'v') { | |||
| this.element.prepend(logoGroup); | |||
| d3.select(this.element).insert(function() { | |||
There was a problem hiding this comment.
Hmm. Does
d3.select(this.element).insert(logoGroup, ':first-child');work also?
There was a problem hiding this comment.
I tried that initially but it does not work:
There was a problem hiding this comment.
Ha right, does
d3.select(this.element).insert(d3.select(logoGroup), ':first-child');work?
There was a problem hiding this comment.
d3.select(this.element).insert(d3.select(logoGroup), ':first-child');
Also fails with:
Would you prefer that I to turn the snippet from this PR into a one-liner?
There was a problem hiding this comment.
Cool. Thanks for checking!
There was a problem hiding this comment.
Non- 🚫, but at that point the vanilla solution seems simpler:
plotly.js/src/plot_api/subroutines.js
Line 148 in ea7941b
plotly.js/src/lib/svg_text_utils.js
Lines 105 to 106 in ea7941b
There was a problem hiding this comment.
Thanks @alexcjohnson! I agree it is simpler. Done in commit 4b164a2
Updated demo https://plnkr.co/edit/3Rfo4svtr6PUDCiCRM3l?p=preview
|
Nicely done 💃 ! |
|
💃 (bis). Nice job! |
Fixes #3489