Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More hovertemplates! #3530

Merged
merged 7 commits into from
Feb 15, 2019
Merged

More hovertemplates! #3530

merged 7 commits into from
Feb 15, 2019

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Feb 8, 2019

checking out a few boxes off #3437

cc @plotly/plotly_js @nicolaskruchten I'll push a commit for hovertemplate + parcats at some point next week. I might even try adding support for hovertemplate for a few traces before 1.45.0 is ready.

- i.e. scatter3d, surface, mesh3d, cone, streamtube and isosurface!
@etpinard etpinard added this to the v1.45.0 milestone Feb 8, 2019
@etpinard etpinard mentioned this pull request Feb 8, 2019
@nicolaskruchten
Copy link
Contributor

Awesome! These are the missing few for px :D

@etpinard
Copy link
Contributor Author

I put parcats + hovertemplate on hold until #3437 (comment) is resolved:

Hmm well, I guess for parcats we could use the line container and then maybe coerce a hovertemplate inside each dimensions item? Or maybe have the root hovertemplate apply to all the dimensions/nodes and be ignored when hovering on links?

but now heatmap, contour, histogram2d, histogram2dcontour and scattercarpet have support for hovertemplate.

@etpinard
Copy link
Contributor Author

parcats has now hover-template support, making this thing status: reviewable.

@antoinerg would you mind reviewing this one?

@antoinerg
Copy link
Contributor

antoinerg commented Feb 15, 2019

Thank you @etpinard for adding support for hovertemplate to that many traces 💪 . The addition of arrayOk to hovertemplate is also very welcome 🔥

In summary, this PR adds support to the following traces:

  • cone (with new test)
  • contour (with new test)
  • heatmap (with new test)
  • histogram (with new test)
  • histogram2d (with new test)
  • histogram2dcontour (with new test)
  • isosurface (with new test)
  • mesh3d (with new test)
  • parcats (with new test)
  • scatter3d (with new test)
  • scattercarpet (with new test)
  • splom (with new test)
  • streamtube (with new test)
  • surface (with new test)

We don't have hovertemplate tests for every single trace but that was probably overkill anyway since most of them reuse the same code pathway.

I say this is ready to 💃

@etpinard
Copy link
Contributor Author

We don't have hovertemplate tests for every single trac

Yes I think we do, at least I tried. See the hover_label_test.js and gl3d_plot_interact.js suites.

@antoinerg
Copy link
Contributor

antoinerg commented Feb 15, 2019

@etpinard I confirm that you added tests to all the traces for which hovertemplate support was added in this PR! Amazing 😄

💃

@etpinard etpinard merged commit c5bdee9 into master Feb 15, 2019
@etpinard etpinard deleted the hovertemplate-more branch February 15, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants